Skip to content

Migrate database missing checks #41460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 6 commits into from
Nov 28, 2023
Merged

Migrate database missing checks #41460

come-nc merged 6 commits into from
Nov 28, 2023

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 14, 2023 •
edited
Loading

Summary

Migrate Database checks for missing columns, indices and primary keys to the new SetupCheck API.

TODO

  • missing columns
  • missing indices
  • missing primary keys

Checklist

@come-nc come-nc added the 2. developing Work in progress label Nov 14, 2023
@come-nc come-nc self-assigned this Nov 14, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 14, 2023
View reviewed changes
@come-nc come-nc mentioned this pull request Nov 14, 2023
Closed
33 tasks
@come-nc come-nc force-pushed the feat/migrate-forwarded-for-headers-check branch from c7637e8 to 0ebd44a Compare November 20, 2023 10:36
@come-nc come-nc force-pushed the feat/migrate-database-missing-checks branch from 2efb953 to d18338e Compare November 20, 2023 10:40
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 20, 2023
Base automatically changed from feat/migrate-forwarded-for-headers-check to master November 21, 2023 08:50
@come-nc come-nc marked this pull request as ready for review November 21, 2023 08:51
@come-nc come-nc added this to the Nextcloud 28 milestone Nov 21, 2023
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991, juliusknorr, nickvergessen and sorbaugh and removed request for a team and sorbaugh November 21, 2023 08:52
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@come-nc come-nc force-pushed the feat/migrate-database-missing-checks branch from d18338e to 6c6436c Compare November 23, 2023 08:34
nickvergessen
nickvergessen approved these changes Nov 23, 2023
View reviewed changes
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 23, 2023

/backport to stable28

@come-nc come-nc force-pushed the feat/migrate-database-missing-checks branch from f458add to 9a1f5ed Compare November 27, 2023 14:23
@come-nc come-nc requested review from Altahrim and artonge November 27, 2023 14:38
@come-nc come-nc merged commit 624f8f8 into master Nov 28, 2023
@come-nc come-nc deleted the feat/migrate-database-missing-checks branch November 28, 2023 13:06
@come-nc
Copy link
Contributor Author

come-nc commented Dec 4, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 4, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Altahrim Altahrim Altahrim approved these changes

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

7 participants

@come-nc @AndyScherzinger @nickvergessen @Altahrim @artonge @blizzz