refactor(carddav): Use even earlier return and SQL's WHERE IN #41474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
3. to review
ChristophWurst
requested review from
miaulalala and
tcitworld
as code owners
ChristophWurst
changed the title
miaulalala
approved these changes
Nov 15, 2023
tcitworld
approved these changes
Nov 15, 2023
* Early return can operate on the input array * SQL can check be used to check for address book ID inclusion Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/carddav/earlier-return-sql-where-in
branch
from
fa8e248 to
5cdbd10
Compare
ChristophWurst
added
4. to release
ChristophWurst
deleted the
refactor/carddav/earlier-return-sql-where-in
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found while reviewing #41457.
Checklist