Skip to content

Migrate opcache check to new SetupCheck API #41547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 5 commits into from
Jan 8, 2024
Merged

Migrate opcache check to new SetupCheck API #41547

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f13a1a
Migrate opcache check to new SetupCheck API
come-nc Nov 16, 2023
989b5ff
Remove unused properties from CheckSetupControllerTest
come-nc Nov 16, 2023
f6df5da
Remove unsupported <code> tag and use quotes instead
come-nc Dec 12, 2023
c92fbca
Fix small psalm issue
come-nc Dec 12, 2023
94d0399
Improve PHP opcache setup check and reduce level in some cases
come-nc Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix small psalm issue 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Jan 8, 2024
commit c92fbca6e6e7ab3833113f562a98cf09ded518a8
2 changes: 1 addition & 1 deletion apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ protected function getOpcacheSetupRecommendations(): array {

if (
// Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size
($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) &&
($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?? 0 < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) &&
(
empty($status['interned_strings_usage']['free_memory']) ||
($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9)
Expand Down