Skip to content

enh(settings): Migrate admin settings for sharing to vue #41581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 3 commits into from
Nov 20, 2023
Merged

enh(settings): Migrate admin settings for sharing to vue #41581

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22163c6
enh(settings): Migrate admin settings for sharing to vue
susnux Nov 16, 2023
8fc0395
fix(config): Adjust webpack config to provide `appName` and `appVersi…
susnux Nov 16, 2023
543e2db
chore: Compile assets
susnux Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(config): Adjust webpack config to provide appName and `appVersi… 
…on` which are expected by `@nextcloud/vue`

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Nov 20, 2023
commit 8fc0395d611fcf7b5904bb04a360530b63903744
7 changes: 7 additions & 0 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ const NodePolyfillPlugin = require('node-polyfill-webpack-plugin')
const WorkboxPlugin = require('workbox-webpack-plugin')

const modules = require('./webpack.modules.js')
const { readFileSync } = require('fs')

const appVersion = readFileSync('./version.php').toString().match(/OC_VersionString[^']+'([^']+)/)?.[1] ?? 'unknown'

const formatOutputFromModules = (modules) => {
// merge all configs into one object, and use AppID to generate the fileNames
Expand Down Expand Up @@ -205,6 +208,10 @@ module.exports = {
},
}],
}),

// Make appName & appVersion available as a constants for '@nextcloud/vue' components
new webpack.DefinePlugin({ appName: JSON.stringify('Nextcloud') }),
new webpack.DefinePlugin({ appVersion: JSON.stringify(appVersion) }),
],
externals: {
OC: 'OC',
Expand Down