fix(CSP): Only add strict-dynamic when using nonce
#41583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
|
Tested with Talk on iOS and Talk on Android and both work with this PR again! |
susnux
requested review from
Altahrim,
ChristophWurst,
SystemKeeper,
juliusknorr and
nickvergessen
AndyScherzinger
approved these changes
Nov 18, 2023
juliusknorr
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using
strict-dynamicwill invalidate everyselfallowed source, so it only makes sense together with nonce.Otherwise browsers not supporting CSP 3.0 will break.
Checklist