feat(search): hide search provider from list #41646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
requested review from
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
artonge
approved these changes
Nov 21, 2023
nfebe
reviewed
Nov 21, 2023
nfebe
approved these changes
Nov 21, 2023
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Apart from one in-line worry, this works.
Altahrim
force-pushed
the
feat/hide-search-provider
branch
from
e328a87 to
bf3a68f
Compare
Some search providers can be hidden if they send `null` in `getOrder` Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
feat/hide-search-provider
branch
from
bf3a68f to
0d8aa68
Compare
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Nov 30, 2023
Possible since nextcloud/server#41646 Signed-off-by: Joas Schilling <[email protected]>
3 tasks
backportbot-nextcloud bot
pushed a commit
to nextcloud/spreed
that referenced
this pull request
Nov 30, 2023
Possible since nextcloud/server#41646 Signed-off-by: Joas Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullingetOrder