Focus global search input on open #41652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Nov 22, 2023
marcoambrosini
requested changes
Nov 23, 2023
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Tested and doesn't work for me.
Wouldn't it be better to watch isVisible and call focusInput whenever the value flips to true?
nfebe
force-pushed
the
global-search-focus-input
branch
from
097219b to
32230cc
Compare
Contributor
Author
Resolved @marcoambrosini |
nfebe
force-pushed
the
global-search-focus-input
branch
from
32230cc to
55830a4
Compare
Member
|
/compile amend / |
For better accesibility, the search input in the global search modal should be focused when the search modal is opened. Resolves: #41651 Signed-off-by: fenn-cs <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
global-search-focus-input
branch
from
55830a4 to
8c6c0d1
Compare
AndyScherzinger
approved these changes
Nov 23, 2023
Member
|
What about the failing cypress tests? |
Member
none of them seem even remotely connected to this change-set |
Member
|
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better accesibility, the search input in the global search modal should be focused when the search modal is opened.
Resolves: #41651