-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(UserMenu): add target property to usermenu component #41659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(UserMenu): add target property to usermenu component #41659
Conversation
4d9756b to
fb009e9
Compare
|
I don't think the admin settings should open in a new tab all the time? cc @nextcloud/designers |
fb009e9 to
c9d4e40
Compare
|
This is an old one.. I agree with the proposed change. I think that admin settings and personal settings, and all apps for that matter, should open in another tab. This solution:
So by insisting on loading different things in the same tab in pursuit of the big single page application feel, we're effectively discouraging users from using the multitasking feature that comes with a web browser. @nextcloud/designers please go and take a look at other (multi-app) projects, the usual suspects. All of them open apps and global settings in new tabs, despite the fact that their loading times are in general faster than ours. (Testing their loading times vs. my local docker loading times). |
|
Hm... I think I don't like this idea. New tabs usually should only be opened for links to external services or if it is really necessary IIRC... |
That is just a convention that seems to be born out of not wanting users to navigate away from your site. Not a UX rule. As per the necessity of it, I think here it's warranted because of the reasons I mentioned above. And our friends at G & M, that have all the UX research resources that they want, reached that conclusion too. |
Fine by me then 👍 |
c9d4e40 to
c7a9d02
Compare
6ad0f1b to
5962797
Compare
5962797 to
7f0aed1
Compare
|
@nickvergessen please review this PR |
ebc2167 to
ce22dcc
Compare
…ponent Signed-off-by: Fitrah Munir <[email protected]>

Summary
Add target property to UserMenu and UserMenuEntry components and add target "_blank" to Administration settings
TODO
Checklist