test boolean favorite #41668
Merged
test boolean favorite #41668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <[email protected]>
Member
Author
|
This only test the boolean search; it does not check if favorites file are returned. |
ArtificialOwl
requested review from
a team,
Altahrim,
AndyScherzinger,
artonge,
come-nc,
nfebe and
sorbaugh
and removed request for
a team
artonge
approved these changes
Nov 22, 2023
AndyScherzinger
approved these changes
Nov 22, 2023
Member
|
@ArtificialOwl can you also add tests for the other, supported data types for favorite status? Like before as mentioned by you, it does not check if favorites file are returned - is fine 👍 Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up from #41655