fix(core): Subscribe to navigation changes on mounted for Unified search #41687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable28 |
susnux
force-pushed
the
fix/unified-search-view
branch
from
70ab627 to
f32319b
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/unified-search-view
branch
from
f32319b to
fca05f4
Compare
artonge
approved these changes
Nov 23, 2023
Pytal
approved these changes
Nov 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent too early calls that cause error, as the component is not yet mounted and thus
this.$eldoes not exists.Checklist