fix: add mimetype for eml and msg #41803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
ChristophWurst
approved these changes
Nov 28, 2023
ChristophWurst
added
3. to review
kesselb
requested review from
a team,
ArtificialOwl,
icewind1991,
sorbaugh and
st3iny
and removed request for
a team
ChristophWurst
approved these changes
Nov 29, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested and works, too
Uploaded MSG files are now detected with <d:getcontenttype>application/x-ole-storage</d:getcontenttype>
| private function introduceEmlAndMsgFormatType() { | ||
| $updatedMimetypes = [ | ||
| 'eml' => 'message/rfc822', | ||
| 'msg' => 'application/x-ole-storage', |
Member
There was a problem hiding this comment.
yet I'm wondering if it should be application/vnd.ms-outlook
Member
|
/backport to stable28 |
AndyScherzinger
approved these changes
Nov 29, 2023
This was referenced Nov 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For nextcloud/files_emailviewer#1
Summary
Add mimetype mapping for eml and msg files
TODO
Checklist