Skip to content

[stable28] Always emit search event #41926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Altahrim merged 1 commit into from
Nov 30, 2023
Merged

[stable28] Always emit search event #41926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Always emit search event 
For BOD, it's better to always emit the search event so
 apps (all of which we don't know) responding to this effect would receive notifications when
the search happens within these apps.

Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
@nfebe
nfebe committed Nov 30, 2023
commit df7a1906e80bc833b92d019f6e7e1626e1b8f26d
5 changes: 2 additions & 3 deletions core/src/views/GlobalSearchModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,8 @@ export default {
this.results = []
return
}
if (this.supportFiltering()) {
emit('nextcloud:unified-search.search', { query })
}
// Event should probably be refactored at some point to used nextcloud:global-search.search
emit('nextcloud:unified-search.search', { query })
const newResults = []
const providersToSearch = this.filteredProviders.length > 0 ? this.filteredProviders : this.providers
const searchProvider = (provider, filters) => {
Expand Down
4 changes: 2 additions & 2 deletions dist/core-global-search.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-global-search.js.map
View file
Open in desktop

Large diffs are not rendered by default.