[stable28] Improve share logic for enforced password & expiry date #41934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It's possible for the admin to enforce and expiry date after, some shares have been created. This commit makes possible to update the share with the new admin constraints. * This commit would users to modify enforced expiry to anything within range and less than the enforced limit in the pre-create dialog for public shares. * This commit fixes, unable to update share without updating password. Signed-off-by: fenn-cs <[email protected]>
nfebe
added
4. to release
nfebe
requested review from
AndyScherzinger,
Pytal,
artonge,
blizzz and
juliusknorr
AndyScherzinger
approved these changes
Nov 30, 2023
nfebe
force-pushed
the
41885-manual-backport
branch
from
efc385d to
b84bcde
Compare
nfebe
requested review from
Altahrim,
ArtificialOwl,
ChristophWurst,
JuliaKirschenheuter,
come-nc,
icewind1991,
julien-nc,
miaulalala,
nickvergessen,
provokateurin,
skjnldsv,
st3iny,
susnux,
szaimen and
tcitworld
as code owners
nfebe
force-pushed
the
41885-manual-backport
branch
from
b84bcde to
efc385d
Compare
nickvergessen
removed request for
JuliaKirschenheuter,
blizzz,
julien-nc,
juliusknorr,
miaulalala,
provokateurin,
skjnldsv,
st3iny and
tcitworld
nfebe
changed the title
artonge
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport #41885