[stable28] enh(settings): Load from disabled users endpoint #41949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
requested review from
AndyScherzinger,
artonge,
come-nc and
nickvergessen
AndyScherzinger
approved these changes
Dec 1, 2023
nickvergessen
approved these changes
Dec 1, 2023
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
🙈
But didn't check if pagination works properly when you have 100 disabled users and start searching for a user starting with z
artonge
approved these changes
Dec 5, 2023
Pytal
force-pushed
the
backport/stable28/40169
branch
2 times, most recently
from
9c11e2d to
6a51725
Compare
Signed-off-by: Christopher Ng <[email protected]> (cherry picked from commit 7affbba)
Signed-off-by: Christopher Ng <[email protected]>
This matches what was done in the calls and so fixes getting disabled user list when there are several backends returning disabled users. Signed-off-by: Côme Chilliet <[email protected]> (cherry picked from commit 85e7887)
AndyScherzinger
force-pushed
the
backport/stable28/40169
branch
from
6a51725 to
a9d86c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40169