fix(files): Remove confusing table header labels #41951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
Contributor
Author
|
/backport to stable28 |
Pytal
approved these changes
Dec 1, 2023
ShGKme
approved these changes
Dec 1, 2023
For screen readers the table header was very verbose and confusing, as the SR reads out e.g. "sort list by name button FILENAME" for every row / file. Instead reduce it to "name button FILENAME" and add information about sorting to caption, as recommended by WCAG [1] [1]: https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/ Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-table-headers
branch
from
32d356d to
57afeb1
Compare
susnux
requested review from
ChristophWurst,
blizzz,
come-nc,
miaulalala,
provokateurin and
tcitworld
as code owners
susnux
changed the base branch from
fix/files-aria-label-on-wrong-element
to
master
susnux
removed request for
ChristophWurst,
blizzz,
come-nc,
miaulalala,
provokateurin and
tcitworld
Contributor
Author
|
Sorry for the noise, Github assigned random people... |
Contributor
Author
|
/backport bb12b8e to stable28 |
1 similar comment
Contributor
Author
|
/backport bb12b8e to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For screen readers the table header was very verbose and confusing, as the SR reads out e.g. "sort list by name button FILENAME" for every row / file. Instead reduce it to "name button FILENAME" and add information about sorting to caption, as recommended by WCAG 1
Checklist