fix(files): Move aria-label for favorite icon from span to icon

[susnux]

• Resolves: [BITV] 9.4.1.2/3.3 - In the table, in the "Name" column, there are elements that have been marked as favorites with a star icon. (2) #41891

Summary

Move the label from the span to the icon itself

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

/backport to stable28

[susnux]

/backport f79a1ad to stable28

[ShGKme]

BTW, why add optional chaining here? Is it possible that there would be no SVG, or that the SVG element would not have the setAttribute method?

[susnux]

querySelector returns Element | undefined so for defensive programming either check and throw an error or use optional chaining. Otherwise at least casting to SvgElement is required.

But doing non of those results in type errors.

[ShGKme]

querySelector returns Element | undefined

But we select an SVG element here, and we at least know that there is the setAttribute method. No chance el.setAttribute would be undefined. If that was only for TypeScript, IMO, we should use !. or as to fix TS error. (Otherwise, there is an unneeded check in a bundle and runtime).

In theory querySelector could return undefined here, but it would mean that something has changed in <NcIconSvgWrapper> and ?. would hide the issue instead of exposing it.