Skip to content

fix(TemplateManager): Bail early if templatedirectory is empty #41995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Dec 4, 2023
Merged

fix(TemplateManager): Bail early if templatedirectory is empty #41995

nickvergessen merged 1 commit into from
Dec 4, 2023

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 4, 2023

Checklist

@marcelklehr
Copy link
Member Author

marcelklehr commented Dec 4, 2023

/backport to stable28

@marcelklehr
Copy link
Member Author

marcelklehr commented Dec 4, 2023

/backport to stable27

@marcelklehr
Copy link
Member Author

marcelklehr commented Dec 4, 2023

/backport to stable26

ChristophWurst
ChristophWurst reviewed Dec 4, 2023
View reviewed changes
@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Dec 4, 2023
nickvergessen
nickvergessen reviewed Dec 4, 2023
View reviewed changes
ChristophWurst
ChristophWurst approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one

@marcelklehr marcelklehr force-pushed the fix/template-manager-templatedirectory-empty branch from c435eba to 062a0ef Compare December 4, 2023 07:53
@marcelklehr marcelklehr enabled auto-merge December 4, 2023 07:54
@nickvergessen nickvergessen merged commit 1066f7e into master Dec 4, 2023
@nickvergessen nickvergessen deleted the fix/template-manager-templatedirectory-empty branch December 4, 2023 09:39
This was referenced Dec 4, 2023
Merged
Merged
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: templates

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Possibility to disable "Templates" directory creation in the config file

5 participants

@marcelklehr @nickvergessen @ChristophWurst @juliusknorr