Skip to content

fix(security): Handle idn_to_utf8 returning false #41999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Dec 4, 2023
Merged

fix(security): Handle idn_to_utf8 returning false #41999

nickvergessen merged 1 commit into from
Dec 4, 2023

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 4, 2023 •
edited
Loading

  • Resolves: TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, bool given From our instance

Test failed before:

.E..                                                                4 / 4 (100%)

Time: 00:00.017, Memory: 28.00 MB

There was 1 error:

1) lib\Security\RemoteHostValidatorTest::testValid with data set #1 ('com.one-.nextcloud-one.com', false)
TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, bool given

/home/nickv/Nextcloud/29/server/lib/private/Security/RemoteHostValidator.php:56
/home/nickv/Nextcloud/29/server/tests/lib/Security/RemoteHostValidatorTest.php:83


ERRORS!
Tests: 4, Assertions: 3, Errors: 1.

Checklist

@nickvergessen nickvergessen added 3. to review Waiting for reviews security labels Dec 4, 2023
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Dec 4, 2023
@nickvergessen nickvergessen self-assigned this Dec 4, 2023
@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 4, 2023

/backport to stable28

@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 4, 2023

/backport to stable27

@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 4, 2023

/backport to stable26

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 4, 2023
@ChristophWurst ChristophWurst removed their request for review December 4, 2023 09:54
@nickvergessen nickvergessen merged commit 89aa395 into master Dec 4, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/handle-idn_to_utf8-returning-false branch December 4, 2023 10:46
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 4, 2023
Merged
@solracsf
Copy link
Member

solracsf commented Dec 6, 2023

/backport to stable27

This was referenced Dec 7, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@Altahrim Altahrim Altahrim approved these changes

@come-nc come-nc come-nc approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@nickvergessen nickvergessen

Labels

4. to release Ready to be released and/or waiting for tests to finish security

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

7 participants

@nickvergessen @solracsf @marcelklehr @Altahrim @come-nc @ChristophWurst