Skip to content

[stable28] Migrate database missing checks #42013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 6 commits into from
Dec 4, 2023
Merged

[stable28] Migrate database missing checks #42013

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0a72a1
Migrate missing column database check to new API
come-nc Nov 14, 2023
e48e67b
Migrate missing index database check to new API
come-nc Nov 14, 2023
fc2467c
Migrate missing primary key database check to new API
come-nc Nov 14, 2023
b75affa
Switch from deprecated hasPrimaryKey to getPrimaryKey function
come-nc Nov 14, 2023
bd9a5df
fix(tests) Fix CheckSetupControllerTest
come-nc Nov 14, 2023
e57d31f
Missing things in database should be warning, not info
come-nc Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch from deprecated hasPrimaryKey to getPrimaryKey function 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @backportbot-nextcloud
come-nc authored and backportbot-nextcloud[bot] committed Dec 4, 2023
commit b75affa7935305993b4b1786e9a1124b2263907c
2 changes: 1 addition & 1 deletion apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private function getMissingPrimaryKeys(): array {
foreach ($missingPrimaryKeys as $missingPrimaryKey) {
if ($schema->hasTable($missingPrimaryKey['tableName'])) {
$table = $schema->getTable($missingPrimaryKey['tableName']);
if (!$table->hasPrimaryKey()) {
if ($table->getPrimaryKey() === null) {
$primaryKeyInfo->addHintForMissingPrimaryKey($missingPrimaryKey['tableName']);
}
}
Expand Down