Skip to content

[stable28] fix: Properly take show_hidden user setting into account for file listing #42023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 3 commits into from
Dec 5, 2023
Merged

[stable28] fix: Properly take show_hidden user setting into account for file listing #42023

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a938e1
fix: Properly take show_hidden user setting into account for file lis…
juliusknorr Dec 4, 2023
52b9028
fix: Also filter out undefined entries from the file list
juliusknorr Dec 4, 2023
88e9925
chore(assets): Recompile assets
nextcloud-command Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Properly take show_hidden user setting into account for file lis… 
…ting

Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Dec 5, 2023
commit 6a938e1ae958e37301dc14aba999f2eac0c9b28f
10 changes: 8 additions & 2 deletions apps/files/src/views/FilesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,16 @@ export default defineComponent({
},

dirContents(): Node[] {
const showHidden = this.userConfigStore?.userConfig.show_hidden
return (this.currentFolder?._children || [])
.map(this.getNode)
.filter(file => file)
.filter(file => file?.attributes?.hidden !== true)
.filter(file => {
if (!showHidden) {
return file?.attributes?.hidden !== true && !file?.basename.startsWith('.')
}

return true
})
},

/**
Expand Down