Skip to content

Add UserConfigChangedEvent to fire whenever a user config value is changed #42039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sorbaugh merged 1 commit into from
Sep 26, 2025
Merged

Add UserConfigChangedEvent to fire whenever a user config value is changed #42039

sorbaugh merged 1 commit into from
Sep 26, 2025

Conversation

@akhil1508
Copy link
Contributor

@akhil1508 akhil1508 commented Dec 5, 2023

akhil1508
akhil1508 commented Dec 5, 2023
View reviewed changes
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch 4 times, most recently from 037ad05 to b040664 Compare September 16, 2024 12:58
@akhil1508 akhil1508 changed the title Draft: Add UserConfigChangedEvent Add UserConfigChangedEvent to fire whenever a user config value is changed Sep 16, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Sep 16, 2024 •
edited
Loading

Hey @akhil1508
Thanks for the rebase! Let me ask for reviews, and see how we can help you move this forward 👍

@skjnldsv skjnldsv requested review from a team, ArtificialOwl, artonge and come-nc and removed request for a team September 16, 2024 12:59
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews feature: users and groups and removed 2. developing Work in progress labels Sep 16, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Sep 16, 2024
@akhil1508 akhil1508 mentioned this pull request Sep 16, 2024
Open
come-nc
come-nc reviewed Sep 16, 2024
View reviewed changes
@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch 2 times, most recently from 57d68a3 to 3040493 Compare September 17, 2024 13:38
@blizzz blizzz mentioned this pull request Jan 8, 2025
Merged
@come-nc
Copy link
Contributor

come-nc commented Aug 7, 2025

composer run cs:fix is needed for the order of imports as well

@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch 2 times, most recently from 2c8fe5c to bec9e25 Compare August 8, 2025 14:49
@akhil1508
Copy link
Contributor Author

akhil1508 commented Aug 8, 2025

Can you also squash/edit commits to please the conventionnal commits CI?

@come-nc Squashed

@come-nc
Copy link
Contributor

come-nc commented Aug 14, 2025 •
edited
Loading

Tests needs to be adapted

Example error:

365) Test\lib\Config\UserConfigTest::testClearCacheAll
ArgumentCountError: Too few arguments to function OC\Config\UserConfig::__construct(), 6 passed in /home/runner/actions-runner/_work/server/server/tests/lib/Config/UserConfigTest.php on line 294 and exactly 7 expected

This was referenced Aug 22, 2025
Merged
Merged
Merged
@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch from bec9e25 to 79ad6c7 Compare August 29, 2025 13:25
@akhil1508
Copy link
Contributor Author

akhil1508 commented Aug 29, 2025

Tests needs to be adapted

@come-nc sorry, missed that. Fixed now

@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch from 79ad6c7 to 82116d2 Compare August 29, 2025 13:26
This was referenced Sep 2, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 10, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 18, 2025
Merged
@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch from 82116d2 to 9af71a7 Compare September 18, 2025 11:01
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 25, 2025
Merged
susnux
susnux approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the versions need to be adjusted

@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch from 9af71a7 to 8860455 Compare September 26, 2025 08:39
@akhil1508 akhil1508 force-pushed the dev/user-preference-event branch from 1e4c504 to fe30ca8 Compare September 26, 2025 09:00
@akhil1508
Copy link
Contributor Author

akhil1508 commented Sep 26, 2025 •
edited
Loading

Looks good, but the versions need to be adjusted

@susnux done, also rebased and squashed commits

@sorbaugh sorbaugh merged commit 39e2997 into nextcloud:master Sep 26, 2025
184 of 187 checks passed
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@artonge artonge Awaiting requested review from artonge

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

2. developing Work in progress enhancement feature: users and groups

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

8 participants

@akhil1508 @skjnldsv @come-nc @AndyScherzinger @susnux @provokateurin @blizzz @sorbaugh