Skip to content

[stable28] Correct semantics for link opening in global search #42073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Dec 7, 2023
Merged

[stable28] Correct semantics for link opening in global search #42073

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a728bcd
Correct semantics for link opening in global search
nfebe Dec 6, 2023
9ba9493
chore(assets): Recompile assets
nextcloud-command Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correct semantics for link opening in global search 
Following the update of `NcListItem` to allow control over
 where and how passed `hrefs` open, the search result component
 can now make use of these props.

See : nextcloud-libraries/nextcloud-vue#4923

Resolves :  #41800

Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
@nfebe @backportbot-nextcloud
nfebe authored and backportbot-nextcloud[bot] committed Dec 6, 2023
commit a728bcde43d3960abf318b59ef1cd5e46480956c
8 changes: 2 additions & 6 deletions core/src/components/GlobalSearch/SearchResult.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<NcListItem class="result-items__item"
:name="title"
:bold="false"
@click="openResult(resourceUrl)">
:href="resourceUrl"
target="_self">
<template #icon>
<div aria-hidden="true"
class="result-items__item-icon"
Expand Down Expand Up @@ -91,11 +92,6 @@ export default {
thumbnailErrorHandler() {
this.thumbnailHasError = true
},
openResult(url) {
if (url) {
window.location = url
}
},
},
}
</script>
Expand Down