Tooltip outside click, should abort share creation #42126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
click-outside-should-abort-share
branch
from
c591790 to
98ee9d6
Compare
8 tasks
artonge
requested changes
Dec 11, 2023
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Some files seem unrelated
It's unexpected that click outside a tooltip would proceed with the action that could be carried out inside the tooltip. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
click-outside-should-abort-share
branch
from
98ee9d6 to
41061dd
Compare
Debounce `onExpirationChange` to avoid calling `formatDateToString` on invalid on uncompletely inputed date strings. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
click-outside-should-abort-share
branch
from
41061dd to
04e8733
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
artonge
approved these changes
Dec 11, 2023
susnux
approved these changes
Dec 12, 2023
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
Member
1 task
Member
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #42046, #42114