Skip to content

[stable28] enh(oauth2): allowed toggling of aria label #42295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emoral435 merged 1 commit into from
Dec 15, 2023
Merged

[stable28] enh(oauth2): allowed toggling of aria label #42295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enh(oauth2): allowed toggling of aria label 
Signed-off-by: Eduardo Morales <[email protected]>
  • Loading branch information
@emoral435 @backportbot-nextcloud
emoral435 authored and backportbot-nextcloud[bot] committed Dec 15, 2023
commit c8f79702a34b2b44a2c262a27740e353ea43ade6
11 changes: 8 additions & 3 deletions apps/oauth2/src/components/OAuthItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,10 @@
<div class="action-secret">
<code>{{ renderedSecret }}</code>
<NcButton type="tertiary-no-background"
:aria-label="t('oauth2', 'Show client secret')"
:aria-label="toggleAriaLabel"
@click="toggleSecret">
<template #icon>
<EyeOutline :size="20"
:title="t('oauth2', 'Show client secret')" />
<EyeOutline :size="20"/>
</template>
</NcButton>
</div>
Expand Down Expand Up @@ -87,6 +86,12 @@ export default {
return '****'
}
},
toggleAriaLabel() {
if (!this.renderSecret) {
return t('oauth2', 'Show client secret')
}
return t('oauth2', 'Hide client secret')
}
},
methods: {
toggleSecret() {
Expand Down
Loading