fix(settings): Disable renaming for tokens marked to be wiped #42331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
Altahrim,
icewind1991 and
nfebe
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $data = $token->jsonSerialize(); | ||
| $data['canDelete'] = true; | ||
| $data['canRename'] = $token instanceof INamedToken; | ||
| $data['canRename'] = $token instanceof INamedToken && $data['type'] !== IToken::WIPE_TOKEN; |
Check notice
Code scanning / Psalm
DeprecatedClass
come-nc
approved these changes
Dec 18, 2023
susnux
force-pushed
the
fix/auth-token-settings
branch
from
15f7e5d to
1a35635
Compare
emoral435
force-pushed
the
fix/auth-token-settings
branch
from
1a35635 to
9e47461
Compare
This otherwise a WipeException will be thrown when trying to rename Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
/backport to stable28 |
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/auth-token-settings
branch
from
9e47461 to
bba6813
Compare
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This otherwise a WipeException will be thrown when trying to rename (by
getTokenByIdinPublicKeyTokenProvider).Checklist