fix(dav): allow multiple organizers if possible #42339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
3. to review
st3iny
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This is very hacky! However, we want to allow saving events with multiple organizers. Those events are not RFC compliant, but sometimes imported from major external calendar services (e.g. Google). If the current user is not an organizer of the event we ignore the exception as no scheduling messages will be sent anyway. Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/dav/allow-multiple-organizers
branch
from
a906cff to
06aba2a
Compare
| throw $e; | ||
| } | ||
|
|
||
| $addresses = $this->getAddressesForPrincipal($calendarNode->getOwner()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
miaulalala
approved these changes
Dec 18, 2023
Contributor
miaulalala
left a comment
miaulalala
left a comment
There was a problem hiding this comment.
Looks fine to me. Psalm isn't happy :)
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
This was referenced Dec 19, 2023
|
@st3iny: Regarding:
Did you file an CR for SabreDAV to adjust this and get their feedback? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is very hacky! However, we want to allow saving events with multiple organizers. Those events are not RFC compliant, but sometimes imported from major external calendar services (e.g. Google). If the current user is not an organizer of the event we ignore the exception as no scheduling messages will be sent anyway.
I'm not very comfortable touching scheduling code so please have a good look. I can provide test ICS files if necessary.
TODO
Checklist