Skip to content

[stable28] Don't write back .htaccess file on a RO filesystem #42384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Dec 21, 2023
Merged

[stable28] Don't write back .htaccess file on a RO filesystem #42384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Read Only FS return false 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
  • Loading branch information
@solracsf
solracsf committed Dec 21, 2023
commit 4fb8403fb3c6521427749391e2ddfbe7c61e374c
4 changes: 4 additions & 0 deletions lib/private/Setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,10 @@ public static function updateHtaccess() {
\OCP\Server::get(Installer::class)
);

if (!is_writable($setupHelper->pathToHtaccess())) {
return false;
}

$htaccessContent = file_get_contents($setupHelper->pathToHtaccess());
$content = "#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####\n";
$htaccessContent = explode($content, $htaccessContent, 2)[0];
Expand Down