Skip to content

fix: Ensure app menu entries and dashboard welcome message have enough contrast #42401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuliaKirschenheuter merged 2 commits into from
Dec 20, 2023
Merged

fix: Ensure app menu entries and dashboard welcome message have enough contrast #42401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fde6914
fix: Adjust colors of app menu and dashboard
susnux Dec 20, 2023
de57e51
chore: Compile assets
susnux Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Adjust colors of app menu and dashboard 
Those elements are shown directly on the background which has the `color-primary`,
so they need to use `color-primary-text` instead of `color-primary-element-text` for guranteed contrast.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Dec 20, 2023
commit fde6914ae19bb967c1767222b4c6e49add51a2e6
3 changes: 2 additions & 1 deletion apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,8 @@ export default {
background-attachment: fixed;

> h2 {
color: var(--color-primary-element-text);
// this is shown directly on the background which has `color-primary`, so we need `color-primary-text`
color: var(--color-primary-text);
text-align: center;
font-size: 32px;
line-height: 130%;
Expand Down
8 changes: 5 additions & 3 deletions core/src/components/AppMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ $header-icon-size: 20px;
width: 12px;
height: 5px;
border-radius: 3px;
background-color: var(--color-primary-element-text);
background-color: var(--color-primary-text);
left: 50%;
bottom: 6px;
display: block;
Expand All @@ -177,7 +177,8 @@ $header-icon-size: 20px;
width: calc(100% - 4px);
height: calc(100% - 4px);
margin: 2px;
color: var(--color-primary-element-text);
// this is shown directly on the background which has `color-primary`, so we need `color-primary-text`
color: var(--color-primary-text);
position: relative;
}

Expand All @@ -194,7 +195,8 @@ $header-icon-size: 20px;
opacity: 0;
position: absolute;
font-size: 12px;
color: var(--color-primary-element-text);
// this is shown directly on the background which has `color-primary`, so we need `color-primary-text`
color: var(--color-primary-text);
text-align: center;
left: 50%;
top: 45%;
Expand Down