Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 21, 2023

Seems I cleaned up too much in 38480fd
The settings still have their own legacy handlings

/**
* @return string[]
*/
public function getCustomJs(): array {
return $this->customJs;
}
/**
* @param string $custom
* @return self
*/
public function addCustomJs(string $custom): self {
$this->customJs[] = $custom;
return $this;
}



Fix #42158

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 21, 2023
@skjnldsv skjnldsv self-assigned this Dec 21, 2023
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team December 21, 2023 16:47
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2023
@skjnldsv skjnldsv requested review from a team, emoral435 and nfebe and removed request for a team and ArtificialOwl December 21, 2023 16:47
@skjnldsv
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see what happened! LGTM!

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Could not find resource files_external/js/public_key.js to load

4 participants