Skip to content

Conversation

@skjnldsv
Copy link
Member

For approval, after a few discussions with @julien-nc

If some actions returned null, we assume the dev wants a silent batch action.
That way a failure can still keep the failed items selected, but not display the failure (and letting the dev do so!)

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 22, 2023
@skjnldsv skjnldsv requested review from a team, julien-nc and juliusknorr December 22, 2023 10:46
@skjnldsv skjnldsv self-assigned this Dec 22, 2023
@skjnldsv skjnldsv requested review from emoral435, nfebe and sorbaugh and removed request for a team December 22, 2023 10:46
@skjnldsv
Copy link
Member Author

/backport to stable28

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@skjnldsv skjnldsv force-pushed the feat/files-actionf-silent-error branch from 1c30e07 to e407fb6 Compare December 26, 2023 07:48
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 26, 2023
@skjnldsv skjnldsv merged commit 5125c34 into master Dec 26, 2023
@skjnldsv skjnldsv deleted the feat/files-actionf-silent-error branch December 26, 2023 08:49
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@skjnldsv
Copy link
Member Author

/backport 1c30e07 to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@skjnldsv
Copy link
Member Author

#42490

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: files technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants