Skip to content

fix(files): Allow Ctrl/Command click on file entries to open in a new tab #42457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Dec 27, 2023
Merged

fix(files): Allow Ctrl/Command click on file entries to open in a new tab #42457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7f632
fix(files): Allow Ctrl/Command click on file entries to open in a new…
juliusknorr Dec 22, 2023
8bbe06a
chore(assets): Recompile assets
nextcloud-command Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/files/src/components/FileEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ import { showError } from '@nextcloud/dialogs'
import { translate as t } from '@nextcloud/l10n'
import { vOnClickOutside } from '@vueuse/components'
import moment from '@nextcloud/moment'
import { generateUrl } from '@nextcloud/router'
import Vue, { defineComponent } from 'vue'

import { action as sidebarAction } from '../actions/sidebarAction.ts'
Expand Down Expand Up @@ -398,8 +399,14 @@ export default defineComponent({
event.stopPropagation()
},

execDefaultAction(...args) {
this.$refs.actions.execDefaultAction(...args)
execDefaultAction(event) {
event.preventDefault()
if (event.ctrlKey || event.metaKey) {
window.open(generateUrl('/f/{fileId}', { fileId: this.fileid }))
return false
}

this.$refs.actions.execDefaultAction(event)
},

openDetailsIfAvailable(event) {
Expand Down
11 changes: 9 additions & 2 deletions apps/files/src/components/FileEntryGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ import { FileType, Permission, Folder, File as NcFile, NodeStatus, Node, View }
import { getUploader } from '@nextcloud/upload'
import { showError } from '@nextcloud/dialogs'
import { translate as t } from '@nextcloud/l10n'
import { generateUrl } from '@nextcloud/router'
import { vOnClickOutside } from '@vueuse/components'
import Vue from 'vue'

Expand Down Expand Up @@ -281,8 +282,14 @@ export default Vue.extend({
event.stopPropagation()
},

execDefaultAction(...args) {
this.$refs.actions.execDefaultAction(...args)
execDefaultAction(event) {
event.preventDefault()
if (event.ctrlKey || event.metaKey) {
window.open(generateUrl('/f/{fileId}', { fileId: this.fileid }))
return false
}

this.$refs.actions.execDefaultAction(event)
},

openDetailsIfAvailable(event) {
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.