fix(dav): fallback realm for HTTP authentication #42459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
added
bug
3. to review
MichaIng
force-pushed
the
fix/dav/fallback-realm
branch
from
0163837 to
77a8082
Compare
icewind1991
approved these changes
Feb 13, 2024
icewind1991
requested review from
a team,
ArtificialOwl and
sorbaugh
and removed request for
a team
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the WWW-Authenticate header, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case. This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set. Solves: https://help.nextcloud.com/t/thunderbird-dont-save-caldav-password-because-of-missing-httprealm-or-formsubmiturl/93233 Signed-off-by: MichaIng <[email protected]>
MichaIng
force-pushed
the
fix/dav/fallback-realm
branch
from
77a8082 to
91127ed
Compare
skjnldsv
approved these changes
Feb 23, 2024
skjnldsv
added
4. to release
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
|
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/42459/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 91127edc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42459/stable26Error: Failed to push branch backport/42459/stable26: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the
WWW-Authenticateheader, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case.This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set.
To solve the particular linked issue, only
apps/dav/lib/Connector/Sabre/Auth.phpis relevant, but I decided to align this across all DAV authentication APIs and not allow an empty realm in general.TODO
Checklist