Skip to content

WIP - Add bidirectional text support #42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahangarha wants to merge 12 commits into from
Closed

WIP - Add bidirectional text support #42471

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e94743f
Set layout direction based on locale
ghorbani-ali Dec 15, 2023
11056eb
Add unittest for language direction
ahangarha Dec 17, 2023
04f55d1
Improve naming methods, variables and const
ghorbani-ali Dec 19, 2023
bdc6799
Add bidi support in core directory
ahangarha Dec 19, 2023
fee1aeb
Add bidi support in apps directory
ahangarha Dec 20, 2023
e18f429
Update unittest based on the new method name
ghorbani-ali Dec 20, 2023
d7ba707
Fix bakcground position based on direction
ahangarha Dec 23, 2023
e9feb43
Fix shorthand paddings and margins
ahangarha Dec 23, 2023
7875d2f
Fix float and clear
ahangarha Dec 23, 2023
2817ad2
Fix other background-positions
ahangarha Dec 23, 2023
82142aa
Minor fix in link button icon position
ahangarha Dec 24, 2023
e22f565
Update header left and right to start and end
ahangarha Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unittest for language direction 
Signed-off-by: Mostafa Ahangarha <[email protected]>
  • Loading branch information
@ahangarha
ahangarha committed Jan 10, 2024
commit 11056ebadacf17359be3faa5e968ff9896f4032c
18 changes: 18 additions & 0 deletions tests/lib/L10N/FactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,4 +700,22 @@ public function testGetLanguageIterator(bool $hasSession, IUser $iUserMock = nul
$iterator = $factory->getLanguageIterator($iUserMock);
self::assertInstanceOf(ILanguageIterator::class, $iterator);
}

public static function languagesWithRespectedDirection():array {
return [
['en', 'ltr'],
['de', 'ltr'],
['fa', 'rtl'],
['ar', 'rtl']
];
}

/**
* @dataProvider languagesWithRespectedDirection
*/
public function testDirectionForEnLocale(string $lang, string $expectedDirection) {
$factory = $this->getFactory();

self::assertEquals($expectedDirection, $factory->getLanguageDirection($lang));
}
}