Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jan 3, 2024

Summary

With #42457 a regression is introduced due to the event.preventDefault() which prevents link activation

To preserve ctrl-click functionality and fix the non-triggering download we need to set the download action as default so it executes

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Jan 3, 2024
@Pytal Pytal self-assigned this Jan 3, 2024
@Pytal
Copy link
Member Author

Pytal commented Jan 3, 2024

/backport 5e7ba12 to stable28

@Pytal
Copy link
Member Author

Pytal commented Jan 3, 2024

Pushed simpler alternative fixups which moves the event.preventDefault() instead so download does not depend on the file action as before, what do you think @skjnldsv?

@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2024

what do you think @skjnldsv?

Code make sense :)

@Pytal Pytal force-pushed the fix/files-download-default-action branch from 9dce79a to 5267d62 Compare January 6, 2024 00:49
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 6, 2024
@Pytal Pytal enabled auto-merge January 6, 2024 01:05
@Pytal Pytal merged commit 2e10c94 into master Jan 6, 2024
@Pytal Pytal deleted the fix/files-download-default-action branch January 6, 2024 01:27
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants