also filter by storage when getting shares in folder #42638
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
icewind1991
force-pushed
the
shares-in-folder-storage
branch
2 times, most recently
from
1946df3 to
d88170e
Compare
Member
|
Do you know, does this improve/decrease performance of the queries due to index changes? |
Member
Author
|
I would expect filtering by path to be faster with the added filter, filtering by parent should be the same |
nickvergessen
approved these changes
Jan 18, 2024
icewind1991
force-pushed
the
shares-in-folder-storage
branch
from
d88170e to
e8050a3
Compare
icewind1991
force-pushed
the
shares-in-folder-storage
branch
from
e8050a3 to
9f05894
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
shares-in-folder-storage
branch
from
9f05894 to
bfeb97c
Compare
come-nc
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while looking through the code.
Only filtering by
path(when doing the non-shallow search) could otherwise return results from other storages/users.The filter by
parentdoesn't strictly require thestoragefilter but I've added it anyway for consistency.