Skip to content

enh(comments): Add visual labels for editor #42676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Jan 12, 2024
Merged

enh(comments): Add visual labels for editor #42676

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc59a4d
enh(comments): Add always visible labels for comment input
susnux Jan 10, 2024
e24f35d
chore: Compile assets
susnux Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
enh(comments): Add always visible labels for comment input 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Jan 12, 2024
commit cc59a4dfea265e78d7fead8d6cc7c25553a8bc82
4 changes: 4 additions & 0 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@
<NcRichContenteditable ref="editor"
:auto-complete="autoComplete"
:contenteditable="!loading"
:label="editor ? t('comments', 'New comment') : t('comments', 'Edit comment')"
:placeholder="t('comments', 'Write a comment …')"
:value="localMessage"
:user-data="userData"
aria-describedby="tab-comments__editor-description"
Expand Down Expand Up @@ -189,6 +191,7 @@ export default {
// Only change data locally and update the original
// parent data when the request is sent and resolved
localMessage: '',
submitted: false,
}
},

Expand Down Expand Up @@ -249,6 +252,7 @@ export default {
*/
updateLocalMessage(message) {
this.localMessage = message.toString()
this.submitted = false
},

/**
Expand Down