fix(caldav): only call getTimestamp() on actual DateTime data #42696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
added
bug
3. to review
Member
Author
|
/backport to stable28 |
8 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $dateTime = $component['DTSTART'][0]; | ||
| $timestamp = $dateTime->getTimestamp(); | ||
| if($userStatusTimestamp > $timestamp) { | ||
| if($dateTime instanceof DateTimeImmutable && $userStatusTimestamp > $dateTime->getTimestamp()) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
ChristophWurst
approved these changes
Jan 11, 2024
miaulalala
approved these changes
Jan 15, 2024
tcitworld
force-pushed
the
fix-issue-42464
branch
from
2a646f4 to
0b39f9d
Compare
For some reason the value of $component['DTSTART'][0] may not be a DateTimeImmutable Closes #42464 Signed-off-by: Thomas Citharel <[email protected]>
miaulalala
force-pushed
the
fix-issue-42464
branch
from
0b39f9d to
2bfe67c
Compare
ChristophWurst
added
4. to release
|
Isn't this line improperly formatted? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the value of
$component['DTSTART'][0]may not be aDateTimeImmutable.In the case of #42464, the property is a
Property\ICalendar\Date, but that extendsProperty\ICalendar\DateTime, so it should still give us aDateTimeImmutable, but anyway. 🤷Follow-up to #42619 Closes #42464