Skip to content

[stable28] enh(comments): Add visual labels for editor #42745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShGKme merged 2 commits into from
Jan 12, 2024
Merged

[stable28] enh(comments): Add visual labels for editor #42745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f6906
enh(comments): Add always visible labels for comment input
susnux Jan 10, 2024
3f4bc1f
chore(assets): Recompile assets
nextcloud-command Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
<NcRichContenteditable ref="editor"
:auto-complete="autoComplete"
:contenteditable="!loading"
:label="editor ? t('comments', 'New comment') : t('comments', 'Edit comment')"
:placeholder="t('comments', 'Write a comment …')"
:value="localMessage"
:user-data="userData"
aria-describedby="tab-comments__editor-description"
Expand Down Expand Up @@ -187,6 +189,7 @@ export default {
// Only change data locally and update the original
// parent data when the request is sent and resolved
localMessage: '',
submitted: false,
}
},

Expand Down Expand Up @@ -245,6 +248,7 @@ export default {
*/
updateLocalMessage(message) {
this.localMessage = message.toString()
this.submitted = false
},

/**
Expand Down
4 changes: 2 additions & 2 deletions dist/6826-6826.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/6826-6826.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/comments-comments-app.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/comments-comments-app.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/comments-comments-tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/comments-comments-tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.