Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jan 15, 2024

  • Resolves: none

Summary

The ExifProvider does not check if the given $file can be read before attempting to extract metadata. I improved the code a bit by only calling getimagesizefromstring if $file->getContent() is not false.

Checklist

@st3iny st3iny added bug 3. to review Waiting for reviews labels Jan 15, 2024
@st3iny st3iny added this to the Nextcloud 27.1.6 milestone Jan 15, 2024
@st3iny st3iny requested review from artonge and skjnldsv January 15, 2024 08:25
@st3iny st3iny self-assigned this Jan 15, 2024
@blizzz blizzz mentioned this pull request Jan 15, 2024
@st3iny st3iny force-pushed the fix/exif-content-provider-stable27 branch from e451379 to 94d7e45 Compare January 15, 2024 10:21
@st3iny st3iny requested a review from artonge January 15, 2024 10:22
@st3iny st3iny merged commit 400524a into stable27 Jan 15, 2024
@st3iny st3iny deleted the fix/exif-content-provider-stable27 branch January 15, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants