Skip to content

[stable28] Tooltip outside click, should abort share creation #42779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 3 commits into from
Jan 18, 2024
Merged

[stable28] Tooltip outside click, should abort share creation #42779

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67e3367
Tooltip outside click, should abort share creation
nfebe Dec 8, 2023
b5edb38
Allow user to finish typing date before formatting
nfebe Dec 8, 2023
8b2a107
chore(assets): Recompile assets
nextcloud-command Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Tooltip outside click, should abort share creation 
It's unexpected that click outside a tooltip would proceed with the
 action that could be carried out inside the tooltip.

Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
@nfebe @skjnldsv
nfebe authored and skjnldsv committed Jan 15, 2024
commit 67e3367c48aaa4f2c9aecde1652b38e2340ae185
2 changes: 1 addition & 1 deletion apps/files_sharing/src/components/SharingEntryLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
:aria-label="actionsTooltip"
menu-align="right"
:open.sync="open"
@close="onNewLinkShare">
@close="onCancel">
<!-- pending data menu -->
<NcActionText v-if="errors.pending" icon="icon-error" :class="{ error: errors.pending }">
{{ errors.pending }}
Expand Down