fix(userstatus): catch unique constraint violation #42805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
bug
3. to review
miaulalala
requested review from
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
Contributor
Author
|
/backport to stable28 |
blizzz
approved these changes
Jan 15, 2024
miaulalala
force-pushed
the
fix/42625/unique-constrain-violation-user-status
branch
from
ec04660 to
020c8bf
Compare
Contributor
Author
|
Failing test is OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges (unrelated). @blizzz can I haz force merge possibly? |
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/42625/unique-constrain-violation-user-status
branch
from
020c8bf to
02d077b
Compare
ChristophWurst
added
4. to release
Merged
8 tasks
8 tasks
|
Still happens in 30.0.6.2 |
Member
|
@jendrikw thank you for the feedback. What you are reporting with #42625 (comment) is not the same code path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to how we have our read/write commit set up, sometimes a different process writes to the DB but we don't read it when running a SELECT. We can therefore ignore the Unique Constraint Violation and drop the insert completely.
TODO
Checklist
Screenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not required