fix(dav): ajax request check on public remote endpoints

[skjnldsv]

Fix #42200

Context

The original legacy (8+ years) check used to search for an exact header match

But after #39924 (I think) the check went wrong and we ended up with this

[skjnldsv]

/skjnldsv-backport to stable28

Addressed

[skjnldsv]

Was failing because master was broken with An exception occurred while executing a query: SQLSTATE[HY000]: General error: 1 table oc_appconfig has no column named lazy.
Rebased and cypress works now

[skjnldsv]

#42882

[michnovka]

This fix did not solve everything. I cannot see image previews on public share links (my.cloud/s/XXXXXX), and I see that PROPFIND request to public.php/webdav/ gives the 401 error. Using the workaround mentioned in the original issue - #42200 (comment) fixes this problem

[susnux]

@michnovka are you sure your Webserver correctly forwards all headers to PHP?
Especially X_REQUESTED_WITH

[michnovka]

I am using the nginx config from https://docs.nextcloud.com/server/latest/admin_manual/installation/nginx.html (checked after update to 28.0.2 and it is identical to this one)

[michnovka]

@susnux I confirmed with adding var_dump($_SERVER) to public.php, and yes, all headers are passed. However, the X_REQUESTED_WITH header is not sent by JS request. See below request copied as CURL:

curl 'https://my.cloud/public.php/webdav/' --compressed -X PROPFIND -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0' -H 'Accept: text/plain,application/xml' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate, br' -H 'Content-Type: text/plain;charset=UTF-8' -H 'Content-Length: 608' -H 'Depth: 0' -H 'Origin: https://my.cloud' -H 'Sec-Fetch-Dest: empty' -H 'Sec-Fetch-Mode: cors' -H 'Sec-Fetch-Site: same-origin' -H 'Authorization: Basic TlFQc2lGRnFzQW15eTZTOg==' -H 'Connection: keep-alive' -H 'Cookie: __Host-nc_sameSiteCookielax=true; __Host-nc_sameSiteCookiestrict=true; oc_sessionPassphrase=Tx3WTgJgIEIh0tkzXDMS3SvKZh3uiHenQaheDpb7%2BlDniZLexVDwYR%2F3OBmPBylRMyqnVxioHvVoPE8tTEKMLeUgZcO%2FUw%2Fp6rLLKJIm8hBle%2F2rKCmkn4FGi%2Fegt%2B%2Bj; ochoj4cc0e60=leb2vdq41oc2dr24i8pgvi5puf; nc_username=tomas; nc_token=JQl6MEydCWbUlt43KO%2B0UyEeFb%2BCGFnl; nc_session_id=leb2vdq41oc2dr24i8pgvi5puf' -H 'TE: trailers'

[kesselb]

/backport to stable24

#39924 was manually backported to 24, and therefore we need this change for 24 too.

[backportbot]

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin stable24

# Create the new backport branch
git checkout -b backport/42853/stable24

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 20a0b9cb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42853/stable24

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[kesselb]

Manual backport for 24: #44895