fix(theming): Make sure color-border-maxcontrast fulfills 3:1 contrast
#42887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
JuliaKirschenheuter,
Pytal,
emoral435 and
skjnldsv
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/accessible-border-color
branch
from
d6322db to
18b91ba
Compare
Contributor
Author
|
/skjnldsv-backport to stable28 |
JuliaKirschenheuter
approved these changes
Jan 17, 2024
Contributor
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
Contrast Ratio 3.04:1 😅😅 still passing
Contributor
Author
|
drone unrelated |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need a 3:1 contrast for input fields, that is why
--color-border-maxcontrastwas introduced. But that variable was not guaranteed to have 3:1 contrast.So this adds tests and adjusts the color a bit.
Screenshots
Checklist