enh(files): Allow to copy files into same directory #42889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/copy-in-same-dir
branch
3 times, most recently
from
2034ea9 to
d5427fc
Compare
skjnldsv
requested changes
Jan 18, 2024
artonge
reviewed
Jan 18, 2024
susnux
force-pushed
the
fix/copy-in-same-dir
branch
from
d5427fc to
6a0d4d6
Compare
artonge
approved these changes
Jan 18, 2024
emoral435
reviewed
Jan 19, 2024
emoral435
suggested changes
Jan 19, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Just needs the file part and it LGTM!!
susnux
force-pushed
the
fix/copy-in-same-dir
branch
2 times, most recently
from
ed6589c to
8d835e1
Compare
Contributor
Author
|
@emoral435 can you check again if that still happens for you? |
emoral435
approved these changes
Jan 19, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Checked, and it works perfectly for me now :) sorry for being nitpicky!
Contributor
|
@skjnldsv before we merge this in, it still says that you have requested changes. I'm 99% sure your fine with this, but just to make sure, all the changes now are fine by you, correct? :) |
skjnldsv
approved these changes
Jan 20, 2024
skjnldsv
added
the
4. to release
Signed-off-by: Ferdinand Thiessen <[email protected]>
…py-move-action Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/copy-in-same-dir
branch
from
8d835e1 to
81925a7
Compare
Member
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring back copy to current directory behavior which will clone the file and add a "copy" suffix on the file name.
Checklist