fix header inversion bug #42963
fix header inversion bug #42963
Conversation
szaimen
force-pushed
the
szaimen-patch-1
branch
from
af04af6 to
c2d7586
Compare
szaimen
added
3. to review
|
/backport to stable28 |
| > .header-menu:not(.user-menu) { | ||
| filter: var(--background-image-invert-if-bright); | ||
| // For general | ||
| > .header-menu__trigger { |
There was a problem hiding this comment.
| > .header-menu__trigger { | |
| > button { |
this should work for all I think
There was a problem hiding this comment.
I fear the assistant button is not a button but a link... (anker)
There was a problem hiding this comment.
Also I would rather not risk using the button tag here...
There was a problem hiding this comment.
Then we should probably adjust the two other that do not use .header-menu__trigger.
But for the moment your solution works fine!
There was a problem hiding this comment.
Also I would rather not risk using the button tag here...
button,
a {}?
There was a problem hiding this comment.
or even better only apply to img tag. Everything else should handle it correctly and we prevent future issues
|
/compile amend / |
nextcloud-command
force-pushed
the
szaimen-patch-1
branch
from
28ea962 to
80bb733
Compare
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
blizzz
force-pushed
the
szaimen-patch-1
branch
from
80bb733 to
2dd05ab
Compare
|
manually rebased |
blizzz
added
4. to release
|
CI failure unrleated afaics |
Should fix #42962
I am not really satisfied with the solution but it is what it is...