Skip to content

[stable28] fix(files): fixed aria-desciption logic for last breadcrumb #42984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jan 20, 2024
Merged

[stable28] fix(files): fixed aria-desciption logic for last breadcrumb #42984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(files): fixed home aria-label and desc logic 
Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@emoral435 @skjnldsv
emoral435 authored and skjnldsv committed Jan 20, 2024
commit df15045541b7dba1e510ce6e097c20c8f24206f8
6 changes: 3 additions & 3 deletions apps/files/src/components/BreadCrumbs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
dir="auto"
:to="section.to"
:title="titleForSection(index, section)"
:aria-description="ariaForSection(index, section)"
:aria-description="ariaForSection(section)"
@click.native="onClick(section.to)">
<template v-if="index === 0" #icon>
<Home :size="20"/>
Expand Down Expand Up @@ -118,8 +118,8 @@ export default Vue.extend({
return null
},

ariaForSection(index, section) {
if (index === section.length - 1) {
ariaForSection(section) {
if (section?.to?.query?.dir === this.$route.query.dir) {
return t('files', 'Reload current directory')
}
return null
Expand Down
4 changes: 2 additions & 2 deletions dist/core-common.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-common.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/files-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.