fix(files): Allow to set node name before creating + bring back new-file highlingting #42993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
Pytal,
Raudius,
artonge,
juliusknorr and
skjnldsv
susnux
changed the title
Contributor
Author
|
/backport to stable28 |
susnux
force-pushed
the
fix/files-new-menu
branch
from
ead5917 to
93a8047
Compare
skjnldsv
previously requested changes
Jan 21, 2024
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Very very clean!!! 🚀
Aside from the files:node:focus, looks good to me! Thank you so much :)
This was referenced Jan 24, 2024
susnux
force-pushed
the
fix/files-new-menu
branch
from
93a8047 to
face7a6
Compare
susnux
dismissed
skjnldsv’s stale review
Changes implemented, please re-review
susnux
force-pushed
the
fix/files-new-menu
branch
4 times, most recently
from
5b24397 to
ac567e8
Compare
Contributor
Author
Removed that 👍 |
susnux
force-pushed
the
fix/files-new-menu
branch
from
ac567e8 to
b85f3d2
Compare
susnux
force-pushed
the
fix/files-new-menu
branch
from
b85f3d2 to
6e72b2e
Compare
AndyScherzinger
approved these changes
Feb 8, 2024
Member
|
|
Member
|
Doesn't seem to work for Text files, |
susnux
force-pushed
the
fix/files-new-menu
branch
from
6e72b2e to
675fb51
Compare
…e fileslist * Reactive `openfile` query Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-new-menu
branch
from
675fb51 to
c38140c
Compare
2 tasks
8 tasks
|
Not fixed in 28.0.3 While I can create a file name, the document does not open. Correct behavior is creating a file name and then the document should open automatically. NC27 works fine/appropriately. |
Contributor
Author
|
If you do not have any templates, this indeed does not work. Somehow I missed on of the |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most important: This brings back the ability to select a folder name before creating it - this is required for shares where you can create but not update.
This feature is reused for all new-menu entries, meaning also for new template folder and new files like new text files if text app is installed.
Moreover this fixes:
files:node:openbut opening a file is left as a action provided by the viewer app. So this is now handled by searching for the view action and if not available then at least open the sidebar for more details.Workflow (screen cast)
vokoscreenNG-2024-01-21_02-10-32.mp4
Checklist