[3rdparty] Remove assetic #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
MorrisJobke
force-pushed
the
remove_assetic
branch
from
3a060b1 to
ca57f75
Compare
Member
|
I force pushed to update the merged 3rdparty repo :) |
Member
|
Other +1s are given in nextcloud/3rdparty#5 -> merging |
This was referenced Jul 7, 2022
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
…of enable/disable increased to 60. (nextcloud#430) If ExApp is resource-heavy, stopping it now does not always free up resources (only if it is implemented in ExApp itself, which is quite rare) That is why we add this PR to turn off the docker container when clicking the "disable" button on ExApp. With "manual installation" - nothing changes, we have nothing to turn off and this is not supported. Also, the timeout for a request to ExApp to turn on/off has been raised from **30 seconds to 60 seconds**, which is still acceptable for UI so as not to seem slow; Resolves: nextcloud#410 Signed-off-by: Alexander Piskun <[email protected]>
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
…tcloud#436) After the previous PR(nextcloud#430) which added stopping application containers feature when shutting down, as @andrey18106 correctly noted during our 1:1 conversation: we cannot rely on the application inside the docker container to be ready to process the request at the moment the docker container is turned on. This PR introduces handling of it by checking health-check and heartbeat. Signed-off-by: bigcat88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #418
Requires: nextcloud/3rdparty#5