Skip to content

chore: Migrate to built-in NcSelect input label #43041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pytal wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

chore: Migrate to built-in NcSelect input label #43041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e466bd
chore(files): Silent NcSelect label warnings
Pytal Jan 23, 2024
567d011
chore(files_sharing): Silent NcSelect label warnings
Pytal Jan 23, 2024
a0f60ad
chore(settings): Migrate to built-in NcSelect input label
Pytal Jan 23, 2024
92c3abf
chore(systemtags): Migrate to built-in NcSelect input label
Pytal Jan 23, 2024
4a5b661
chore(user_status): Silent NcSelect label warnings
Pytal Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(systemtags): Migrate to built-in NcSelect input label 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Jan 23, 2024
commit 92c3abf9ca9c66742912218a1885be24c3b11136
6 changes: 2 additions & 4 deletions apps/systemtags/src/components/SystemTagForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@
</h3>

<div class="system-tag-form__group">
<label for="system-tags-input">{{ t('systemtags', 'Search for a tag to edit') }}</label>
<NcSelectTags v-model="selectedTag"
input-id="system-tags-input"
:input-label="t('systemtags', 'Search for a tag to edit')"
:placeholder="t('systemtags', 'Collaborative tags …')"
:fetch-tags="false"
:options="tags"
Expand All @@ -56,9 +55,8 @@
</div>

<div class="system-tag-form__group">
<label for="system-tag-level">{{ t('systemtags', 'Tag level') }}</label>
<NcSelect v-model="tagLevel"
input-id="system-tag-level"
:input-label="t('systemtags', 'Tag level')"
:options="tagLevelOptions"
:reduce="level => level.id"
:clearable="false"
Expand Down
7 changes: 1 addition & 6 deletions apps/systemtags/src/components/SystemTags.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@
:name="t('systemtags', 'Loading collaborative tags …')"
:size="32" />
<template v-else>
<label for="system-tags-input">{{ t('systemtags', 'Search or create collaborative tags') }}</label>
<NcSelectTags class="system-tags__select"
input-id="system-tags-input"
:input-label="t('systemtags', 'Search or create collaborative tags')"
:placeholder="t('systemtags', 'Collaborative tags …')"
:options="sortedTags"
:value="selectedTags"
Expand Down Expand Up @@ -224,10 +223,6 @@ export default Vue.extend({
display: flex;
flex-direction: column;

label[for="system-tags-input"] {
margin-bottom: 2px;
}

&__select {
width: 100%;
:deep {
Expand Down