fix: Allow to disable multipart copy on external s3 storage #43060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/s3-external-multipart-copy
branch
from
219382d to
0ea4eee
Compare
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Altahrim
approved these changes
Jan 24, 2024
come-nc
approved these changes
Jan 29, 2024
Member
Author
|
I'll extend this with a global config to not require to change all configs manually. |
Signed-off-by: Julius Härtl <[email protected]>
skjnldsv
force-pushed
the
fix/s3-external-multipart-copy
branch
from
0ea4eee to
d576b8e
Compare
skjnldsv
added
4. to release
This was referenced Feb 24, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #41914 (e405437)
As we cannot detect if multipart copy is supported there is a config flag added in the earlier pull request. However for external storages we need to expose this flag so the admin can disable it if needed.